feat(AzureTranslator): remove HttpClient service inject#893
Merged
feat(AzureTranslator): remove HttpClient service inject#893
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the explicit registration of the default HttpClient factory from the Azure Translator DI setup, relying instead on the hosting application's own HttpClient configuration while keeping the AzureTranslator service and options registrations unchanged. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/components/BootstrapBlazor.AzureTranslator/Extensions/ServiceCollectionExtensions.cs:23` </location>
<code_context>
public static IServiceCollection AddBootstrapBlazorAzureTranslator(this IServiceCollection services, Action<
AzureTranslatorOption>? configOptions = null)
{
- services.AddHttpClient();
-
services.AddSingleton<IAzureTranslatorService, AzureTranslatorService>();
</code_context>
<issue_to_address>
**issue (bug_risk):** Removing AddHttpClient may break existing consumers that relied on this extension to register HttpClient.
This now requires applications to register `AddHttpClient` themselves. If `AzureTranslatorService` (or its dependencies) use `HttpClient`/`IHttpClientFactory`, callers that only invoke `AddBootstrapBlazorAzureTranslator(...)` may see runtime failures. If this is intentional, please document the new requirement and verify all consumers already configure `HttpClient`, or add a clearer guard/failure mode around the dependency.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/components/BootstrapBlazor.AzureTranslator/Extensions/ServiceCollectionExtensions.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR removes an unnecessary AddHttpClient() service registration from the AzureTranslator component and bumps the version to 10.0.1. The removal is appropriate since the AzureTranslatorService implementation uses the Azure SDK's TextTranslationClient, which manages its own HTTP communication internally, rather than requiring an injected HttpClient or IHttpClientFactory.
Key changes:
- Removed unnecessary
services.AddHttpClient()call from service registration - Bumped package version to 10.0.1
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ServiceCollectionExtensions.cs | Removed unnecessary HttpClient service registration that was not being used by AzureTranslatorService |
| BootstrapBlazor.AzureTranslator.csproj | Added explicit version 10.0.1 to the project properties |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #892
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: